Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typedoc-plugin-markdown dependency #2610

Open
maschad opened this issue Jun 24, 2024 · 9 comments · May be fixed by #2650
Open

Upgrade typedoc-plugin-markdown dependency #2610

maschad opened this issue Jun 24, 2024 · 9 comments · May be fixed by #2650
Assignees
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute

Comments

@maschad
Copy link
Member

maschad commented Jun 24, 2024

Dependabot is unable to upgrade this https://github.com/FuelLabs/fuels-ts/actions/runs/9649869028/job/26614245232?pr=2599 so it needs to be done manually.

This dependency should be upgraded to latest version and all CI tests should pass.

@maschad maschad added chore Issue is a chore good first issue Suitable for newcomers looking to contribute p2 labels Jun 24, 2024
@arboleya arboleya added this to the 0.x post-launch milestone Jun 24, 2024
@maschad maschad changed the title Upgrade typedoc-plugin-markdown Upgrade typedoc-plugin-markdown dependency Jun 24, 2024
@bolajahmad
Copy link

Could I take this on? I'm looking to contribute to fuel-ts and this could be a good issue to start with

@petertonysmith94
Copy link
Contributor

Hey @bolajahmad 👋🏼

We welcome all contributions and would value your help. Let us know if you need any assistance 😄

@bolajahmad
Copy link

Hey @bolajahmad 👋🏼

We welcome all contributions and would value your help. Let us know if you need any assistance 😄

Will do just that!

@aditya172926
Copy link

Hey is this issue still being worked on?
If not, I can take it up if it's assigned to me.

@arboleya
Copy link
Member

Hey @aditya172926, we're not assigning issues to external contributors unless there's a PR for it.

If you create a PR for it, please let us know.

@aditya172926
Copy link

Hey @aditya172926, we're not assigning issues to external contributors unless there's a PR for it.

If you create a PR for it, please let us know.

Cool. Will let you know. 👍

@aditya172926 aditya172926 linked a pull request Jun 30, 2024 that will close this issue
4 tasks
@aditya172926
Copy link

@arboleya i have created a draft pr #2650 for this issue.

Will be adding some more commits for fixing build in the typedoc.json wrt different schema used in typedoc-plugin-markdown 4.1.0

@aditya172926
Copy link

aditya172926 commented Jul 11, 2024

Update for this pr #2650 .

The typedoc_plugin_markdown has been bumped up to the version 4.1.2.
The dev dependencies typedoc and typedoc-plugin-merge-modules have also been updated to 0.26.3 and 6.0.0 respectively for compatibility with typedoc_plugin_markdown.

The updated new versions introduced changes in the structure of the modules after merging when building the docs and executing the current typedoc-postbuild.ts script fails.

Currently wip on updating the typedoc-postbuild.ts script to execute successfully.

@petertonysmith94
Copy link
Contributor

Update for this pr #2650 .

The typedoc_plugin_markdown has been bumped up to the version 4.1.2. The dev dependencies typedoc and typedoc-plugin-merge-modules have also been updated to 0.26.3 and 6.0.0 respectively for compatibility with typedoc_plugin_markdown.

The updated new versions introduced changes in the structure of the modules after merging when building the docs and executing the current typedoc-postbuild.ts script fails.

Currently wip on updating the typedoc-postbuild.ts script to execute successfully.

Wonderful - thanks you @aditya172926! ❤️

If you need any assistance then let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants