-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump typedoc-plugin-markdown version to 4.2.2 #2650
chore: bump typedoc-plugin-markdown version to 4.2.2 #2650
Conversation
You may want to add the following issue as closed to your PR :) |
updated description to add this issue #2713 as well. |
Whenever you get the chance, could you update the description with the new PR template which can be found here. Thanks @aditya172926! |
Hey @aditya172926 thanks for taking this on, could you comment on #2713 so that we can assign that issue to you? Thanks. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FuelLabs/sdk-ts anyone know why the vercel deploy isn't working? Ideally we'll also test this against the docs hub as the directory structure was intended to work there. Any changes in the dir structure to the generated API docs could break the docs hub.
Looks like an authorization for fork deployment is required by a member of fuel labs team on vercel. |
@aditya172926 I have authorised it but doesn't seem to be working. Bare with me. |
@aditya172926 Nicely done ❤️ I've approved the deployment, would you mind resolving the conflicts? Not entirely sure why the checks are not being run though 🤔 |
Conflicts resolved |
@petertonysmith94 I have updated the branch to master. Could you approve workflows to see if they were successful? Some workflows and vercel build failed while executing CI setup in the previous commit. |
Ran the workflows - we will need to test these against the docs-hub to ensure nothing has broken. I'll have time to do this tomorrow for you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built this out locally with the docs-hub
and all looks good to me.
Nice one @aditya172926 🥇 ❤️
Ready from my side. @maschad |
d2a2270
to
0737706
Compare
@aditya172926 I saw a lot of merged changeset within the PR and have pushed up a change to resolve this. Please could you confirm everything looks good from your end, I'll retest the changes in the docs-hub now :) |
I pushed a fix and a small change in the |
583f9e2
to
33753cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @aditya172926 - and your patience 🙏🏼
Reviewed this on the docs hub and all looks good 🚢 .
Found the following issue, however, this is pre-existing.
Thanks to all the help I received from the reviewers 😊 |
…itya172926/chore/typedoc-plugin-markdown
4b7ff9b
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
typedoc-plugin-markdown
dependency #2610typedoc
dependency #2713Summary
typedoc-plugin-markdown
version to the latest version 4.2.2.typedoc
&typedoc-plugin-merge-modules
to 0.26.3 & 6.0.0 respectively for compatibility withtypedoc-plugin-markdown
.typedoc-postbuild.ts
for building docs successfully due to changes introduced in merging modules structure by the latest version packages oftypedoc-plugin-markdown
.Checklist
tests
to prove my changesdocs