Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: re-introduce a section from provider docs #2716

Merged
merged 46 commits into from
Jul 23, 2024
Merged

docs: re-introduce a section from provider docs #2716

merged 46 commits into from
Jul 23, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Jul 6, 2024 •
edited
Loading

Checklist

  • I added — tests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@github-actions github-actions bot added the docs Requests pertinent to documentation label Jul 6, 2024
@mvares mvares marked this pull request as ready for review July 8, 2024 14:36
danielbate
danielbate reviewed Jul 9, 2024
View reviewed changes
apps/docs/src/guide/provider/querying-the-chain.md Outdated Show resolved Hide resolved
apps/docs/src/guide/provider/querying-the-chain.md Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/provider/querying-the-chain.test.ts Outdated Show resolved Hide resolved
@arboleya arboleya added this to the 0.x mainnet milestone Jul 10, 2024
@mvares mvares requested a review from danielbate July 10, 2024 12:53
@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
@mvares
Copy link
Contributor Author

mvares commented Jul 19, 2024

Hey @Torres-ssf! Can you check out?

danielbate
danielbate reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the preview is broken 🤔

@petertonysmith94
Copy link
Contributor

Seems the preview is broken 🤔

This was an old deployment, it should be updated now :)

@Torres-ssf
Copy link
Contributor

Seems the preview is broken 🤔

This was an old deployment, it should be updated now :)

I think it was not working because the preview deployment did not happen.

I had to manually trigger it as it needs to be authorized by one of the official contributors.

@mvares
Copy link
Contributor Author

mvares commented Jul 22, 2024

Locally, it is working. In my opinion, the issue is not due to the code.

Torres-ssf
Torres-ssf requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvares We should have all sections heading using the same standard. The new ones are different from the existing ones:

Existent ones:

Screenshot 2024-07-22 at 09 32 49 Screenshot 2024-07-22 at 09 33 41

New ones:

Screenshot 2024-07-22 at 09 34 27 Screenshot 2024-07-22 at 09 34 37

maschad
maschad approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) July 23, 2024 06:28
@petertonysmith94 petertonysmith94 merged commit 1870f24 into FuelLabs:master Jul 23, 2024
19 of 20 checks passed
@mvares mvares deleted the mv/docs/reintroduce-docs branch July 23, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@maschad maschad maschad approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@mvares mvares

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce getMessages and getMessageProof documentation
6 participants
@mvares @petertonysmith94 @Torres-ssf @danielbate @maschad @arboleya