Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: deploy contract validation #2796

Merged
merged 23 commits into from
Jul 22, 2024
Merged

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jul 18, 2024

Release notes

In this release, we:

  • Limited deployment to contracts up to 100kb

Summary

This is the predecessor to the large contract deployment support in #2741. It introduces two changes, one to throw when deploying contracts greater than 100 KB in size via the ContractFactory. Additionally a change in terminology from invalid -> unsupported tx types to better describe tx support for blob txs.

Breaking Changes

ErrorCode.INVALID_TRANSACTION_TYPE was migrated to ErrorCode.UNSUPPORTED_TRANSACTION_TYPE.

// before
const code = ErrorCode.INVALID_TRANSACTION_TYPE;
// after
const code = ErrorCode.UNSUPPORTED_TRANSACTION_TYPE;

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

@danielbate danielbate added the feat Issue is a feature label Jul 18, 2024
@danielbate danielbate added this to the 0.x mainnet milestone Jul 18, 2024
@danielbate danielbate self-assigned this Jul 18, 2024
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-ts ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 1:17pm

arboleya
arboleya previously approved these changes Jul 19, 2024
.changeset/tall-planes-nail.md Outdated Show resolved Hide resolved
@danielbate danielbate changed the title feat: deploy contract validation feat!: deploy contract validation Jul 19, 2024
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a typo.

packages/fuel-gauge/src/contract-factory.test.ts Outdated Show resolved Hide resolved
@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.39%(+0.03%) 71.61%(-0.04%) 77.32%(+0.02%) 79.52%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

@danielbate danielbate merged commit f3453b9 into master Jul 22, 2024
20 checks passed
@danielbate danielbate deleted the db/feat/unsupported-blob-tx branch July 22, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants