Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back create fuels template metadata #2853

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Jul 29, 2024

Summary

This PR adds back the proper metadata/favicon for the template that got removed in the migration to the Next.js App router.

image

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.35%(-0.01%) 71.5%(-0.15%) 77.32%(+0.02%) 79.48%(-0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 82.31%
(+1.16%)
66.66%
(+2.73%)
82.35%
(+0.54%)
82%
(+1.15%)
🔴 packages/account/src/providers/provider.ts 67.58%
(-1.26%)
61.58%
(-2.24%)
73.49%
(-0.31%)
67.56%
(-1.23%)
🔴 packages/account/src/test-utils/launchNode.ts 98.27%
(+0.01%)
86.88%
(+2.14%)
100%
(+0%)
98.36%
(+0.02%)
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

@petertonysmith94 petertonysmith94 merged commit 4bc0387 into master Jul 30, 2024
20 checks passed
@petertonysmith94 petertonysmith94 deleted the dp/fix-create-fuels-metadata branch July 30, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create fuels template broken metadata
5 participants