feat: add advanced fees when approving a tx request #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helciofranco
requested review from
luizstacio,
pedronauck and
LuizAsFight
as code owners
Base automatically changed from
hf/feat/advanced-fees
to
lf/feat/upgrade-fuels-core-0.24
May 7, 2024 17:41
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 62.16% | 3298/5306 |
| 🔴 | Branches | 41.14% | 648/1575 |
| 🔴 | Functions | 46.89% | 693/1478 |
| 🟡 | Lines | 62.73% | 3179/5068 |
Test suite run success
243 tests passing in 71 suites.
Report generated by 🧪jest coverage report action from c54c0ed
helciofranco
force-pushed
the
hf/feat/advanced-fees-2
branch
from
61e3e23
to
ca56339
Compare
…t/advanced-fees-2
…he transactionRequest
helciofranco
changed the title
LuizAsFight
requested changes
Aug 3, 2024
There was a problem hiding this comment.
when I change gasLimit to a really high value, the fee is not changing at all.. only the tip is changing the fee, can you check if the transaction is being estimated with the inputted gasLimit ? this doesn't stop this PR but we should detect if the problem is in the wallet or in the ts sdk
…t/advanced-fees-2
LuizAsFight
approved these changes
Aug 7, 2024
LuizAsFight
approved these changes
Aug 7, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Aug 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## fuels-wallet@0.25.0 ### Minor Changes - [#1277](#1277) [`87cc8099`](87cc809) Thanks [@helciofranco](https://github.com/helciofranco)! - feat: add custom network fees, offering options like regular, fast and custom tip when approving a transaction through Dapps. ### Patch Changes - [#1424](#1424) [`abfad2e6`](abfad2e) Thanks [@arthurgeron](https://github.com/arthurgeron)! - - Audit check now ignores vulnerabilities with no known patched version - Test utils using act methods deprecated in React 18.3 - Updated dependencies \[]: - @fuel-wallet/connections@0.25.0 ## @fuel-wallet/connections@0.25.0 ## @fuel-wallet/types@0.25.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
Custom Feesfeature from theSend Transactionscreen, enabling users to set a custom fee when approving a request from a Dapp.Screen.Recording.2024-08-01.at.10.43.05.mov