Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fuels pr-2479 to ensure correct operations are shown #1419

Closed
wants to merge 1 commit into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Jul 24, 2024

Summary

When approving a transaction from a dApp, for instance connectors.fuel.network , the operations were not being displayed properly, particularly when there was only an InputMessage in the connecting wallet. This is due to a bug in the fuel-ts SDK where the associated InputMessages and InputCoins were not being returned. This PR seeks to upgrade to that fix, which will eventually be released in fuels-ts v0.92.2

Notes

In the screenshots below is the related fix

image

image

@maschad maschad self-assigned this Jul 24, 2024
@maschad maschad added the bug Something isn't working label Jul 24, 2024
@maschad maschad marked this pull request as draft July 24, 2024 17:32
@maschad
Copy link
Member Author

maschad commented Jul 24, 2024

I think it may be best to cherry-pick the commit once this is merged into master onto a patch release based off v0.88.1

@maschad
Copy link
Member Author

maschad commented Aug 10, 2024

I'm closing this PR as it would be more feasible to upgrade to the latest version of fuels i.e. v0.93.0 as opposed to reconciling all the changes resulting from cherry-picking the fix unto a branch based off v0.88.0 , given the wallet will need to be upgraded to the latest fuels soon regardless.

@maschad maschad closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approve Screen: Randomly not showing operations
1 participant