Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owned Proxy - update scripts and associated docs #20

Merged
merged 43 commits into from
Sep 18, 2024
Merged

Owned Proxy - update scripts and associated docs #20

merged 43 commits into from
Sep 18, 2024

Conversation

K1-R1
Copy link
Member

@K1-R1 K1-R1 commented Aug 22, 2024

Type of change

  • Documentation

Changes

The following changes have been made:

  • Set forc's deploy proxy feature as the recommended usage for the Owned Proxy contract
  • Moved old script docs into sub directory with warnings

Notes

  • The scripts were not removed entirely as some edge-case functionality is not fully covered by forc yet

Related Issues

Closes #14

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@K1-R1 K1-R1 added the documentation Improvements or additions to documentation label Aug 22, 2024
@K1-R1 K1-R1 self-assigned this Aug 22, 2024
@K1-R1
Copy link
Member Author

K1-R1 commented Aug 22, 2024

To be merged after #17

@K1-R1 K1-R1 added the blocked label Aug 22, 2024
@K1-R1 K1-R1 marked this pull request as ready for review August 22, 2024 00:53
@K1-R1 K1-R1 requested a review from a team as a code owner August 22, 2024 00:53
@K1-R1 K1-R1 added the SRC-14 label Aug 22, 2024
@K1-R1 K1-R1 removed the blocked label Sep 8, 2024
SwayStar123
SwayStar123 previously approved these changes Sep 9, 2024
src14/owned_proxy/README.md Outdated Show resolved Hide resolved
src14/owned_proxy/README.md Outdated Show resolved Hide resolved
src14/owned_proxy/README.md Outdated Show resolved Hide resolved
src14/owned_proxy/scripts/README.md Outdated Show resolved Hide resolved
src14/owned_proxy/scripts/README.md Outdated Show resolved Hide resolved
K1-R1 and others added 6 commits September 12, 2024 23:28
Co-authored-by: Cameron Carstens <bitzoic.eth@gmail.com>
Co-authored-by: Cameron Carstens <bitzoic.eth@gmail.com>
Co-authored-by: Cameron Carstens <bitzoic.eth@gmail.com>
Co-authored-by: Cameron Carstens <bitzoic.eth@gmail.com>
@K1-R1 K1-R1 enabled auto-merge September 12, 2024 22:31
@K1-R1 K1-R1 merged commit a3eb2a6 into master Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SRC-14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Owned Proxy - update scripts and associated docs
4 participants