Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open graph logo, updated send request button in the patient form, updated spacing between practice logo and name #111

Merged
merged 9 commits into from
Sep 27, 2023

Conversation

NuriyaAkh
Copy link
Collaborator

Description

Updated the Open Graph logo URL to use the correct image URL hosted on 'https://connectient.co/'.
Modified the "Send Request" button in the patient form for improved user experience.
Adjusted the spacing between the practice logo and name for better visual alignment.

Related Issue

closes #103

Acceptance Criteria

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
💯 Add tests
🔗 Update dependencies
📜 Docs

Updates

Before

After

Screenshot 2023-09-19 at 2 11 15 PM Screenshot 2023-09-19 at 2 11 47 PM

Testing Steps / QA Criteria

@@ -4,8 +4,19 @@ import { Toaster } from '@/components/ui/toaster';
import './globals.css';

export const metadata = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with this!! I think the current logo we're using is /connectient-logo.png

@@ -483,7 +483,7 @@ const AppointmentForm = ({
(form.formState.isDirty && !form.formState.isValid)
}
>
Request Appointment
Send Request
</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good choice with this. The text is shorter and makes the button smaller,

url: 'https://connectient.co/',
images: [
{
url: '/connectient.png',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the path that needs to be updated

const ogImage = logo || '/connectient-logo.png';
const ogMetadata = {
title: name,
description: 'Appointments Made hi Easy',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here with the hi


const ogImage = logo || '/connectient-logo.png';
const ogMetadata = {
title: name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NuriyaAkh The practice title is coming through, which is great, but not the practice logo. Did you get this in your testing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see open graph images, my pr ready for review

@5hraddha 5hraddha self-requested a review September 21, 2023 14:35
@@ -9,6 +9,54 @@ import { redirect } from 'next/navigation';

const supabase = createServerComponentClient<Database>({ cookies });

export async function generateMetadata({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this async function defined here, but is it being called anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the generateMetadata function needed to fetch metadata that requires dynamic values.
https://nextjs.org/docs/app/building-your-application/optimizing/metadata

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @NuriyaAkh !

Copy link
Collaborator

@5hraddha 5hraddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @NuriyaAkh 🚀 Awesome!

Copy link
Contributor

@mentalcaries mentalcaries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@5hraddha 5hraddha merged commit ebd205d into main Sep 27, 2023
1 check passed
@5hraddha 5hraddha deleted the na-logo-styles branch September 27, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Appointment Button (patient form) looks off on mobile Screens
3 participants