-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open graph logo, updated send request button in the patient form, updated spacing between practice logo and name #111
Conversation
src/app/layout.tsx
Outdated
@@ -4,8 +4,19 @@ import { Toaster } from '@/components/ui/toaster'; | |||
import './globals.css'; | |||
|
|||
export const metadata = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with this!! I think the current logo we're using is /connectient-logo.png
@@ -483,7 +483,7 @@ const AppointmentForm = ({ | |||
(form.formState.isDirty && !form.formState.isValid) | |||
} | |||
> | |||
Request Appointment | |||
Send Request | |||
</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good choice with this. The text is shorter and makes the button smaller,
src/app/layout.tsx
Outdated
url: 'https://connectient.co/', | ||
images: [ | ||
{ | ||
url: '/connectient.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the path that needs to be updated
src/app/[practiceCode]/book/page.tsx
Outdated
const ogImage = logo || '/connectient-logo.png'; | ||
const ogMetadata = { | ||
title: name, | ||
description: 'Appointments Made hi Easy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here with the hi
src/app/[practiceCode]/book/page.tsx
Outdated
|
||
const ogImage = logo || '/connectient-logo.png'; | ||
const ogMetadata = { | ||
title: name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NuriyaAkh The practice title is coming through, which is great, but not the practice logo. Did you get this in your testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see open graph images, my pr ready for review
@@ -9,6 +9,54 @@ import { redirect } from 'next/navigation'; | |||
|
|||
const supabase = createServerComponentClient<Database>({ cookies }); | |||
|
|||
export async function generateMetadata({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this async function defined here, but is it being called anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the generateMetadata function needed to fetch metadata that requires dynamic values.
https://nextjs.org/docs/app/building-your-application/optimizing/metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @NuriyaAkh !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @NuriyaAkh 🚀 Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
Updated the Open Graph logo URL to use the correct image URL hosted on 'https://connectient.co/'.
Modified the "Send Request" button in the patient form for improved user experience.
Adjusted the spacing between the practice logo and name for better visual alignment.
Related Issue
closes #103
Acceptance Criteria
Type of Changes
Updates
Before
After
Testing Steps / QA Criteria