Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retries and ratelimiting #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Floppy012
Copy link
Contributor

This PR is a continuation of #38. The codebase has changed a bit since that PR was opened so I decided do make a new one. This PR is somewhat inspired by #38.

I've made some changes to make enabling/configuring the rate limiter / retries simpler. These two features are disabled by default. For the rate limiter I've added a var that contains a configuration that matches Blizzard's rate limits.

It probably needs some documentation in the readme file to make people aware of the features.

Disclaimer: I'm still learning golang :)

@FuzzyStatic FuzzyStatic self-assigned this Oct 29, 2023
@FuzzyStatic FuzzyStatic added the enhancement New feature or request label Oct 29, 2023
@FuzzyStatic
Copy link
Owner

Can you add a small example main.go in the examples folder demonstrating your retry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants