Hide sharing behind feature flag

G-Ray · Jan 7, 2025 · 7f17939 · 7f17939
1 parent 8f4101c
commit 7f17939
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -112,7 +112,7 @@ git clone --recurse-submodules git@github.com:G-Ray/pikatorrent.git pikatorrent
 cd pikatorrent/app
 ./vcpkg/bootstrap-vcpkg.sh # .bat for Windows
 export VCPKG_ROOT=/absolut/path/to/./app/vcpkg
-flutter run
+flutter run # optionally specify --dart-define-from-file=.env
 ```
 
 ## Localization

diff --git a/app/.env b/app/.env
@@ -0,0 +1 @@
+ENABLE_LINK_SHARING=true
diff --git a/app/lib/screens/torrents/torrent_list_tile/torrent_list_tile.dart b/app/lib/screens/torrents/torrent_list_tile/torrent_list_tile.dart
@@ -54,9 +54,8 @@ class TorrentListTile extends StatelessWidget {
                   : torrent.progress == 1
                       ? const Icon(Icons.download_done)
                       : const Icon(Icons.download),
-              tooltip: torrent.status == TorrentStatus.stopped
-                  ? 'Start'
-                  : 'Stop',
+              tooltip:
+                  torrent.status == TorrentStatus.stopped ? 'Start' : 'Stop',
             )),
           ]),
         ),
@@ -83,12 +82,14 @@ class TorrentListTile extends StatelessWidget {
             ? Row(
                 mainAxisSize: MainAxisSize.min,
                 children: [
-                  IconButton(
-                      tooltip: 'Share',
-                      onPressed: () => shareLink(context, torrent.magnetLink!),
-                      icon: const Icon(
-                        Icons.share,
-                      )),
+                  if (const bool.fromEnvironment('ENABLE_LINK_SHARING') == true)
+                    IconButton(
+                        tooltip: 'Share',
+                        onPressed: () =>
+                            shareLink(context, torrent.magnetLink!),
+                        icon: const Icon(
+                          Icons.share,
+                        )),
                   IconButton(
                       tooltip: 'Remove',
                       onPressed: () => showDialog(
@@ -165,4 +166,3 @@ class TorrentListTile extends StatelessWidget {
     });
   }
 }
-
diff --git a/app/lib/screens/torrents/torrents.dart b/app/lib/screens/torrents/torrents.dart
@@ -81,12 +81,15 @@ class _TorrentScreen extends State<TorrentsScreen>
                         motion: const ScrollMotion(),
                         extentRatio: 0.4,
                         children: [
-                          SlidableAction(
-                            backgroundColor: Colors.blue,
-                            onPressed: (_) =>
-                                shareLink(context, torrent.magnetLink!),
-                            icon: Icons.share,
-                          ),
+                          if (const bool.fromEnvironment(
+                                  'ENABLE_LINK_SHARING') ==
+                              true)
+                            SlidableAction(
+                              backgroundColor: Colors.blue,
+                              onPressed: (_) =>
+                                  shareLink(context, torrent.magnetLink!),
+                              icon: Icons.share,
+                            ),
                           SlidableAction(
                             backgroundColor: Colors.red,
                             onPressed: (_) => showDialog(