Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added navBar #9

Closed
wants to merge 3 commits into from
Closed

Added navBar #9

wants to merge 3 commits into from

Conversation

mrshivamshaw
Copy link
Member

@mrshivamshaw mrshivamshaw commented Oct 20, 2023 •
edited
Loading

Related Issue #1

Proposed Changes

Added NavBar and also routers which will make the work easier for other contributers

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

github-actions[bot]
github-actions bot reviewed Oct 20, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings from GDSC AEC! Thanks for making the PR, our team will review it soon. Stay tuned 😊

@mrshivamshaw
Copy link
Member Author

Screenshot 2023-10-20 212612

TheCodeVenturer
TheCodeVenturer requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@TheCodeVenturer TheCodeVenturer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shivamshaw07, our website is SPA so

  • we do not need react-router now, if will need in the future will implement it,
  • Make only Navbar Component rest leave on others
  • Follow the Figma Design Strictly.

@mrshivamshaw
Copy link
Member Author

@TheCodeVenturer ok bhaiya

@mrshivamshaw mrshivamshaw closed this by deleting the head repository Oct 21, 2023
@mrshivamshaw mrshivamshaw mentioned this pull request Oct 21, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@TheCodeVenturer TheCodeVenturer TheCodeVenturer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrshivamshaw @TheCodeVenturer