Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed clone bug in ctm_setup #53

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Dec 20, 2024

The standard cloning process was not properly editing ctm_post.j
and therefore the old EXPDIR string was not being changed to the new EXPDIR string.
This was due to the non-standard form of that file.

Two fixes are now included: ctm_post.j has a new format which will now work with the standard cloning process,
and that process (in ctm_setup) has been modified to account for ctm_post.j in the old format.

@mmanyin mmanyin added the bug-fix Fixes a bug label Dec 20, 2024
@mmanyin mmanyin requested a review from a team as a code owner December 20, 2024 23:02
@mmanyin mmanyin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 20, 2024
@mmanyin
Copy link
Contributor Author

mmanyin commented Dec 20, 2024

Tagging this "zero diff" since the model itself has not changed, only the post-processing for cloned experiments

@mmanyin mmanyin merged commit e23ab57 into main Dec 23, 2024
6 of 8 checks passed
@mmanyin mmanyin deleted the feature/mmanyin/fix_clone_bug branch December 23, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bug-fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants