Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace aircraft bias CSV files with new nc4 files to use with updated bias correction #478

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

replace aircraft bias CSV files with new nc4 files to use with updated bias correction #478

wants to merge 17 commits into from

Conversation

gmao-msienkie
Copy link
Contributor

Description

Several scripts are updated to remove reference to the CSV bias files and enable generation and use of the new netCDF4 format files.

Dependencies

  • waiting on GEOS-ESM/repo/pull/<pr_number>
  • waiting on GEOS-ESM/repo/pull/<pr_number>

Impact

  • repo
  • ...

@gmao-msienkie
new configuration with NC4 bias file for aircraft bias coefficients -…
2b7f11c 
… modified aircraft.yaml

to use the new file, and modified gsi_bc_to_ioda.py to generate the NC4 coeff. file
Working on get_observations.py to get the NC4 aircraft bias coefficient file instead of csv
@gmao-msienkie
change indentation of 'obs bias' section
5ecfbdf 
(it's not a part of obs space)
@gmao-msienkie
some modifications - not yet running
1db9244
@gmao-msienkie
Merge branch 'develop' into feature/msienkie/aircraft_bias_NC4
5228376
@gmao-msienkie
Try 'satbias' type in get_observations.py (?)
a791130 
additions for gsi_bc_to_ioda.py - use an aircraft 'sensor'
@gmao-msienkie
Copy link
Contributor Author

My code has 'ascent rate' where the develop had had the ridiculous 'windUpward' before. I guess 'instantaneousAltitudeRate' is OK too.

@gmao-msienkie
remove old 'csv' processing that was left in the missing_obs_test file
077845b 
change aircraftAscentRate to instantaneousAltitudeRate to conform with
recently changed nomenclature
@gmao-msienkie
Merge branch 'develop' into feature/msienkie/aircraft_bias_NC4
3bc0c80 
resolved merge conflict for aircraft.yaml files
update aircraft.yaml in missing obs test
@Dooruk Dooruk requested review from gmao-yzhu and rtodling December 6, 2024 20:25
@gmao-msienkie
Added missing line for appending info on output to yaml
b1e2a2a 
Fixed typo: add 'predictors' not 'default predictors' to output
@gmao-msienkie
Needed to update the predictor coefficient name to match the new
ab672a4 
naming convention.  Use 'instantaneousAltitudeRate' and
'instantaneousAltitudeRate_order_2'
@gmao-msienkie
Copy link
Contributor Author

current status:

  • The updated src/swell/tasks/gsi_bc_to_ioda.py seems to be working okay
  • For src/swell/tasks/get_observations.py I gave the aircraft coefficient file the type 'satbias' which mean I also had to provide a fake satbias_pc file. I didn't think I wanted to stick with 'csv'. Maybe at some point the r2d2 could use the newer name "obsbias_coefficients" in r2d2. I have some sample files stored in my R2D2DataStore on nobackup
  • The RunJediHofxExecutable task fails. "Bad parameter: getAllIndices: Can't find element in the vector" The bias correction configuration was copied from ufo/test/testinput/instrumentTests/Aircraft_obs/aircraft_geos_qc.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmao-yzhu gmao-yzhu Awaiting requested review from gmao-yzhu

@rtodling rtodling Awaiting requested review from rtodling

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gmao-msienkie