Initial implementation of the passwordreset page #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts router , locales and the login page have been updated to support the new passwordreset page.
CodeNamedRobin
requested changes
Oct 14, 2023
There was a problem hiding this comment.
There are some console logs left in there.
There was a problem hiding this comment.
These are now gone in the latest commit to this branch.
src/views/PasswordResetView.vue
Outdated
| const passwordResetMode = ref(0); | ||
| const email = emailForm.defineComponentBinds('email'); | ||
| const password = passwordForm.defineComponentBinds('password'); | ||
| const password2 = passwordForm.defineComponentBinds('password2'); |
There was a problem hiding this comment.
Might be nicer and more informative to refactor password2 to passwordConfirm?
There was a problem hiding this comment.
Updated in the latest commit to this branch.
src/views/PasswordResetView.vue
Outdated
| </script> | ||
|
|
||
| <style scoped lang="scss"> | ||
| //TODO Cleanup and fix |
There was a problem hiding this comment.
Please add a link to #14.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes to:
Fixes: #24