Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change object names in responses #119

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Change object names in responses #119

wants to merge 5 commits into from

Conversation

bonaparten
Copy link
Contributor

@bonaparten bonaparten commented Feb 9, 2021 •
edited
Loading

Description

Reduce to only two kinds of response:

 - response
    - result[]

and

- response
  - groupByResult[]
    - groupByObject: string[]
    - result[]

Corresponding issue

Closes #16

New or changed dependencies

Checklist

  • My code follows the code-style rules, and I have checked on the static analyses
    - I have commented my code
    - I have written javadoc (required for public methods)
    - I have added sufficient unit and API tests
  • I have made corresponding changes to the documentation
  • I have updated the CHANGELOG.md
  • I have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.

@bonaparten bonaparten added the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Feb 9, 2021
@bonaparten bonaparten added this to the 2.0 milestone Feb 9, 2021
@bonaparten bonaparten force-pushed the change-object-names-in-responses branch 3 times, most recently from d8ca442 to 158c660 Compare February 9, 2021 15:44
@bonaparten bonaparten changed the title 🚧 Change object names in responses WIP: Change object names in responses Feb 10, 2021
@bonaparten bonaparten requested a review from FabiKo117 February 10, 2021 13:41
@bonaparten bonaparten self-assigned this Feb 10, 2021
@bonaparten bonaparten added breaking This will introduce an incombability to previous versions. Documentation update compulsory waiting An issue or PR which is waiting for an upstream bugfix, further information or is somehow blocked. labels Feb 11, 2021
@bonaparten bonaparten force-pushed the change-object-names-in-responses branch 2 times, most recently from 52fbfdc to 5e42f00 Compare February 16, 2021 15:22
@bonaparten bonaparten changed the title WIP: Change object names in responses Change object names in responses Feb 18, 2021
@bonaparten bonaparten force-pushed the change-object-names-in-responses branch from 5e42f00 to 22058ea Compare February 24, 2021 10:48
@mcauer
Copy link
Member

mcauer commented Jun 7, 2021

What about #84 ? Is this s.th. different or will it be included here?

@bonaparten
Copy link
Contributor Author

It could be included here, but we didn't discuss it further since these are all breaking changes that we will introduce with the release 2.0 of the ohsome API. This will be released most likely after summer. So some time is still to come.

@tyrasd tyrasd removed the request for review from FabiKo117 April 20, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking This will introduce an incombability to previous versions. Documentation update compulsory code quality Topics around code quality, e.g. refactoring, better naming of methods/classes waiting An issue or PR which is waiting for an upstream bugfix, further information or is somehow blocked.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Why are there different object names in the response of /groupBy/boundary and /ratio/groupByBoundary?
3 participants
@bonaparten @mcauer @tyrasd