fix: error with canvas when deleting selected vertices in list

Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
GIScience · Oct 29, 2024 · 7cf2825 · 7cf2825
1 parent 8687fe3
commit 7cf2825
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -41,6 +41,10 @@ RELEASING:
  -->
 
 ## Unreleased
+
+### Fixed
+- Error with canvas scenes when deleting selected vertices in list ([#278](https://github.com/GIScience/orstools-qgis-plugin/pull/278))
+- 
 ### Added
 - Processing algorithms for the Network Export endpoint ([#210](https://github.com/GIScience/orstools-qgis-plugin/issues/210))
 

diff --git a/ORStools/gui/ORStoolsDialog.py b/ORStools/gui/ORStoolsDialog.py
@@ -579,7 +579,7 @@ def _on_clear_listwidget_click(self) -> None:
             self._clear_annotations()
 
         # Remove blue lines (rubber band)
-        if self.line_tool:
+        if self.line_tool and hasattr(self.line_tool, "rubberBand"):
             self.line_tool.canvas.scene().removeItem(self.line_tool.rubberBand)
 
     def _linetool_annotate_point(

diff --git a/ORStools/utils/maptools.py b/ORStools/utils/maptools.py
@@ -92,6 +92,7 @@ def canvasDoubleClickEvent(self, e):
         # noinspection PyUnresolvedReferences
         self.doubleClicked.emit()
         self.canvas.scene().removeItem(self.rubberBand)
+        del self.rubberBand
 
     def deactivate(self):
         super(LineTool, self).deactivate()