Code cleanup #147
Merged
Code cleanup #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koebi
reviewed
Jun 8, 2021
switch from old OpenRouteService spelling to openrouteservice refers to #133
refers to #133
in case the minimum QGIS version increase is an issue, a wrapper can be written similar to https://github.com/nextgis/quickmapservices/commit/fb3c0bb74c2f87fe053066c8ca05ba04c659ef39\#diff-87e8111ebf019c6ae2fcb99140c4a89701083728afafe06083e2edd416883cd8R119-R124 refers to #133
refers to #133
Add inspection exception where variables are needed for underlying c functions that are not imported correctly by the python wrapper refers to #133
refers to #133
Add inspection exceptions where references can't be found due to wrapper types refers to #133
refers to #133
Removes redundancies in processing algorithm classes by creating the ORSBaseProcessingAlgorithm class. Moved to base class: - basic attributes and functions - provider and output parameter - algorithm and ors_client initialization Other notable changes: - moved from class to instance attribute approach - clean algorithm class naming - build_default_parameters moved to directions_core - easier access to input values in processAlgorithm() - rename of help files for dynamic loading - moved from lookupField() to indexOf() closes #133
TheGreatRefrigerator
force-pushed
the
code_cleanup
branch
from
9cd0fc4 to
d48c21a
Compare
removed the reformatting commit |
|
Looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.