merge :: (#10) MainView-Publishing #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a36e067.
Tmdhoon2
requested changes
Oct 14, 2024
.../java/com/example/killergram_android_v1/feature/enterinfo/enterSkill/EnterSkillsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/killergram_android_v1/feature/home/HomeActivity.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
HomeViewModel 생성자에 아무 값도 없어서 당장은 필요없을 것 같은데 확장성 고려해서 만들어두신 건가요??
There was a problem hiding this comment.
HomeViewModel에는 LiveData가 있는 것으로 알고있는데 생성자에 값이 없다는 말씀이 무엇을 의미하시는 지 이해를 못하였습니다ㅠ
There was a problem hiding this comment.
HomeViewModel에는 생성자에 값이 없어요.
코틀린에서 생성자는 클래스 이름 옆에 열린 ()를 의미합니다.
생성자에 값이 없다는건 객체 생성 시 전달하는 값이 없다는 의미입니다.
근데 뷰모델 팩토리는 보통 뷰모델 생성자에 값을 넣어주기 위해 사용합니다.
그래서 말씀드린겁니다!
app/src/main/java/com/example/killergram_android_v1/feature/login/LoginActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
하위 레벨의 폴더가 파일 없이 존재하게 되면 상위 폴더와 겹쳐져서 임의의 파일을 생성해두었습니다. 다른 파일로 대체할 예정입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
homeView 제작, 캘린더 기능, 운동 리스트(recyclerView를 곁들인), view 선택 상태처리(enterSkills) 등을 구현하였습니다.
