Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LevelMaintainerTerminal rework logic inside TileLevelMaintainer #162

Merged

Conversation

Laiff
Copy link

@Laiff Laiff commented Oct 9, 2023

Close GT-New-Horizons-Modpack#14554

Ready for review

  1. Reworked registry to show in terminal
  2. Reworked storage and scheduling inside LevelMaintaner (old storage format support migration on load)
  3. Added new terminal to show level devices
  4. Support back navigation inside terminals
  5. Implemented InterfaceWireless using new solution

Functionality of new terminal described in attached issue

@Laiff Laiff force-pushed the feature/level-maintainer-terminal branch from 9abbbd9 to cbcb910 Compare October 9, 2023 23:19
@Laiff
Copy link
Author

Laiff commented Oct 9, 2023

Final interface
image

@Dream-Master Dream-Master requested review from firenoo and a team October 10, 2023 07:15
@Laiff Laiff force-pushed the feature/level-maintainer-terminal branch 2 times, most recently from 4ffa72e to 1a81100 Compare October 12, 2023 09:41
@Dream-Master
Copy link
Member

Dream-Master commented Oct 13, 2023

I just try to add your new pr but i run in issues and it wont build

i just combined them with firenoos changes the other pr in the mod

D:\Github\AE2FC\src\main\java\com\glodblock\github\client\gui\GuiFluidCraftConfirm.java:19: error: types com.glodblock.github.client.gui.IGuiTooltipHandler and appeng.client.gui.IGuiTooltipHandler are incompatible;
public class GuiFluidCraftConfirm extends GuiCraftConfirm implements IGuiTooltipHandler {
       ^
  class GuiFluidCraftConfirm inherits unrelated defaults for handleItemTooltip(ItemStack,int,int,List<String>) from types com.glodblock.github.client.gui.IGuiTooltipHandler and appeng.client.gui.IGuiTooltipHandler```

@Laiff Laiff force-pushed the feature/level-maintainer-terminal branch from db71dbc to 63b507e Compare October 21, 2023 19:42
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for using different texture from AE2 for "highlight tile" button?

@Laiff
Copy link
Author

Laiff commented Oct 26, 2023

Any reason for using different texture from AE2 for "highlight tile" button?

This icon more readable in small format and have better correlation with it function. Plan to replace it in AE2 too but not now. And style of all icons on buttons here uniformed

@Laiff Laiff requested a review from miozune October 26, 2023 13:46
dependencies.gradle Outdated Show resolved Hide resolved
Copy link
Member

@miozune miozune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not capable of going through every single change, but it looks good overall.
Update AE2 dep to non-pre one before merge.

@Dream-Master Dream-Master merged commit f5912ef into GTNewHorizons:master Oct 27, 2023
1 check passed
@Laiff Laiff deleted the feature/level-maintainer-terminal branch October 27, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ME level maintainer - Add Level Maintainer Terminal and wireless version vice versa
4 participants