-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LevelMaintainerTerminal
rework logic inside TileLevelMaintainer
#162
Add LevelMaintainerTerminal
rework logic inside TileLevelMaintainer
#162
Conversation
9abbbd9
to
cbcb910
Compare
4ffa72e
to
1a81100
Compare
I just try to add your new pr but i run in issues and it wont build i just combined them with firenoos changes the other pr in the mod
|
no root cause was found
keyword `net.bdew.neiaddons.appeng.AppEngGuiHandler`
db71dbc
to
63b507e
Compare
# Conflicts: # dependencies.gradle
…ner-terminal # Conflicts: # dependencies.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for using different texture from AE2 for "highlight tile" button?
src/main/java/com/glodblock/github/coremod/registries/LevelTerminalRegistry.java
Show resolved
Hide resolved
src/main/java/com/glodblock/github/network/wrapper/FCNetworkWrapper.java
Show resolved
Hide resolved
src/main/java/com/glodblock/github/common/tile/TileLevelMaintainer.java
Outdated
Show resolved
Hide resolved
This icon more readable in small format and have better correlation with it function. Plan to replace it in AE2 too but not now. And style of all icons on buttons here uniformed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not capable of going through every single change, but it looks good overall.
Update AE2 dep to non-pre one before merge.
Close GT-New-Horizons-Modpack#14554
Ready for review
Functionality of new terminal described in attached issue