Use MathExpressionParser from GTNHLib. #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated accordingly with GTNewHorizons/Applied-Energistics-2-Unofficial#497. Since * That UI really needs to be cleaned up, but that's a problem for another day. |
OneEyeMaker
reviewed
Mar 24, 2024
src/main/java/com/glodblock/github/client/gui/GuiLevelMaintainer.java
Outdated
Show resolved
Hide resolved
OneEyeMaker
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GTNHLib is present, the new
MathExpressionParser(see GTNewHorizons/GTNHLib#31) will be used to parse values. As far as I can tell this is a proper superset of features of the built-in AE parser; allowing the player to order large amounts of items by typing expressions line10kand such.I hope this can make it to 2.6.0 at the last moment; the parser itself has been feature-complete for a while, it just has not been linked to in AE. I consider this "spiritually" to be a part of the numeric widget reworks in ModularUI earlier, and it would be nice if it worked in some of the most used UIs in the pack too.