Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluid Artificial Universe Cell #218

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Jul 23, 2024

Add cell for FC like in this pr: GTNewHorizons/Applied-Energistics-2-Unofficial#529
Related issue: GTNewHorizons/GT-New-Horizons-Modpack#16663
image
The number of bytes can't be increased without breaking the limit of long in some places

@LazyFleshWasTaken
Copy link

Why is it with 63 types and not 5 like the other aefc multi fluid cells?

@MCTBL
Copy link
Member Author

MCTBL commented Jul 23, 2024

Why is it with 63 types and not 5 like the other aefc multi fluid cells?

image
because the item cell is 63 types, I prefer make them same

@S4mpsa
Copy link

S4mpsa commented Jul 23, 2024

Every other multi-fluid cell is only 5 types. There is no reason why this should change.

Also, "Fluid Artificial Universe Cell" is a silly name. I would propose "ME Fluid Quasar Cell" instead.

Generally, I don't see as much need for this one compared to the item variant. That was added primarily for enabling some fancy automation in Stargate tier instead of as an actual storage option. I'm not aware of any cell-shuffling setups that use fluid cells, so this seems to be primarily for fluid storage, but we have multiple "infinite" options for that already.

However, if this is added, I can make a recipe for it.

@MCTBL
Copy link
Member Author

MCTBL commented Jul 24, 2024

Every other multi-fluid cell is only 5 types. There is no reason why this should change.

Also, "Fluid Artificial Universe Cell" is a silly name. I would propose "ME Fluid Quasar Cell" instead.

Generally, I don't see as much need for this one compared to the item variant. That was added primarily for enabling some fancy automation in Stargate tier instead of as an actual storage option. I'm not aware of any cell-shuffling setups that use fluid cells, so this seems to be primarily for fluid storage, but we have multiple "infinite" options for that already.

However, if this is added, I can make a recipe for it.

that sounds more reasonable.I was thinking too simply.
QQ_1721811445795

Copy link

@S4mpsa S4mpsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal ID being "artificial" instead of "universe" is a bit odd, but otherwise everything looks good to me.
Don't see any reason to not have a fluid variant of the cell.

@MCTBL
Copy link
Member Author

MCTBL commented Jul 24, 2024

The internal ID being "artificial" instead of "universe" is a bit odd, but otherwise everything looks good to me. Don't see any reason to not have a fluid variant of the cell.

well, I'm not good at naming something, so i just simply use the name from ur pr😂

@S4mpsa
Copy link

S4mpsa commented Jul 24, 2024

I need to change some other names of the fluid stuff anyways, I'll do that in a separate PR.

The internal name of the Item variant is .Universe instead of .artifical as here, which I was referring to with the comment.
item.appliedenergistics2.ItemExtremeStorageCell.Universe.name=Artificial Universe Cell

@MCTBL
Copy link
Member Author

MCTBL commented Jul 24, 2024

I need to change some other names of the fluid stuff anyways, I'll do that in a separate PR.

The internal name of the Item variant is .Universe instead of .artifical as here, which I was referring to with the comment. item.appliedenergistics2.ItemExtremeStorageCell.Universe.name=Artificial Universe Cell

OK, i will change it a bit later

@Dream-Master Dream-Master merged commit a0db8e3 into GTNewHorizons:master Jul 28, 2024
1 check passed
@MCTBL MCTBL deleted the Artificial_Universe_Cell branch August 3, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants