Fix fluid is registered twice in crafting CPU #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did basically the same but didn't have the time to test it back then, did now and it fixes the issue. Another one popped up where final output of a crafting in a CPU can go into the negatives, but that is actually consistent with the behavior with items so an AE2 bug not fluid crafting bug. |
Demiu
reviewed
Nov 9, 2024
src/main/java/com/glodblock/github/common/tile/TileFluidDiscretizer.java
Outdated
Show resolved
Hide resolved
RecursivePineapple
approved these changes
Nov 22, 2024
lordIcocain
pushed a commit
to lordIcocain/AE2FluidCraft-Rework
that referenced
this pull request
Nov 27, 2024
Co-authored-by: Martin Robertz <dream-master@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#17853
Description, see