NEI Bookmark Pulling for AE2 #372
Conversation
firenoo
added
the
ongoing freeze - do not merge
src/main/java/appeng/integration/modules/NEIHelpers/NEIAEBookmarkContainerHandler.java
Outdated
Show resolved
Hide resolved
firenoo
removed
the
ongoing freeze - do not merge
firenoo
force-pushed
the
NEI_Bookmark_Pulling
branch
2 times, most recently
from
1b55bc6
to
3c00e10
Compare
|
Don't merge yet, I forgot to test the ME Chest ingame after registering it in the API. |
|
Okay the feature does work for ME chests! Sorry for the delay :v) |
|
@Nilau1998 is the pr done? i ask Firenoo and he said no. |
|
Very sorry, I was tired that time and read it "does not" work with ME chests so I was waiting to see if it would be fixed. I'll do some QA when I have time |
|
Going classify this as a bug. I have 2 stacks of stone in my bookmarks, and my inventory is full of stone 1x stacks. I pull, and get only 126 instead of the full 128. This happens with other stack amounts; it only chooses 2 slots to fill, |
|
Bug above is true when pulling 2 types, for each type |
|
Will probably need to rebase again... |
What is wrong? Why rebase |
firenoo
force-pushed
the
NEI_Bookmark_Pulling
branch
from
2fb28c6
to
e69f2d3
Compare
|
i dont want to see stuff from the main branch on side branches |
|
ah ok clean history |
|
@firenoo but beside this is the pr now ok ? |
src/main/java/appeng/integration/modules/NEIHelpers/NEIAEBookmarkContainerHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/appeng/integration/modules/NEIHelpers/NEIAEBookmarkContainerHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/appeng/integration/modules/NEIHelpers/NEIAEBookmarkContainerHandler.java
Outdated
Show resolved
Hide resolved
add forgotten import
firenoo
force-pushed
the
NEI_Bookmark_Pulling
branch
from
e69f2d3
to
b0e5098
Compare
Continuation of the Bookmark Pulling API implemented in a previos PR (GTNewHorizons/NotEnoughItems#410 (review)). This time we are getting the same logic but for AE2 Panels and the Skystone Chests.
The Skystone chests sadly needed a bunch of logic implemented to get the movement by simulating player clicks. If there is any other way I'll gladly implement it using that, I couldn't find anything to simply move items in the the default AE2 code however which is why I feel back to the TransferManager from NEI for inspiration.
Regular Terminals use the packet system to request items from the ME System and transfer them into the players inventory.
Showcase this implementation where a player would want to get all components for a Fusion Reactor from the Terminals and some Steam machinery from Skychests.
https://youtu.be/cJofSS__P_s