Fix sticky storages break autocrafting #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroscho
added a commit
to hiroscho/AE2FluidCraft-Rework
that referenced
this pull request
Aug 10, 2024
tth05
requested changes
Aug 11, 2024
|
Seems like this change crashes my server with the following crashlog: crash-2024-08-12_12.12.17-server.txt |
|
I removed the getter and setter from the InventoryHandler and MonitorHandler since those were mainly required to set the status for ae2fc. |
Dream-Master
added a commit
to GTNewHorizons/AE2FluidCraft-Rework
that referenced
this pull request
Aug 18, 2024
* Fix fluid autocrafting Depends on GTNewHorizons/Applied-Energistics-2-Unofficial#545 * update * update * rename * Add FluidCraftingInventoryHandler so that fluid crafting isn't handled in Pass 2 * update deps --------- Co-authored-by: hiroscho <hiroscho.games@gmail.com> Co-authored-by: Dream Master <dream-master@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GTNewHorizons/GT-New-Horizons-Modpack#16152
The current implementation always tries to store into sticky inventories first. If there is any sticky inventory that can store the item, it will not attempt to insert into any non-sticky inventories.
This breaks autocrafting since the item will never be injected into the CraftingGridCache.
GTNewHorizons/AE2FluidCraft-Rework#221 is related to this PR. The ae2fc PR will allow sticky inventory autocrafting to work with fluids too.