Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide P2P outputs from interface terminal #610

Merged
merged 10 commits into from
Nov 17, 2024
Merged

Hide P2P outputs from interface terminal #610

merged 10 commits into from
Nov 17, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Nov 13, 2024

Replaces this PR : #606
Fixes : GTNewHorizons/GT-New-Horizons-Modpack#17920

Additionally clean up a bit the highlight render code by removing duplicate calls, merging everything into one single class with only one public method, use the tesselator to draw the highlight instead of direct gl calls.

Fix not rendering the hightlight if it's in another world, now it will say that you are not in the correct world and if you quickly switch dimensions it will be rendering.

This code is called by AE2FC and GT5u, I made 2 PRs to correct it :

@Alexdoru Alexdoru marked this pull request as ready for review November 13, 2024 16:13
@Alexdoru Alexdoru requested a review from a team November 13, 2024 16:20
@boubou19 boubou19 enabled auto-merge (squash) November 17, 2024 21:57
@boubou19 boubou19 merged commit 8d802d1 into master Nov 17, 2024
1 check passed
@boubou19 boubou19 deleted the hide-p2p-outputs branch November 17, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface Terminal displays the P2P interfaces outputs
3 participants