Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP Hud fix #59

Merged
merged 5 commits into from
Oct 20, 2024
Merged

LP Hud fix #59

merged 5 commits into from
Oct 20, 2024

Conversation

Fabboz
Copy link

@Fabboz Fabboz commented Oct 6, 2024

fix lp hud with waila and botania when targeting a block like grass and with mana bar present.
I took the hud code of the Thaumcraft sanity checker as a reference.

this is the bug before the commit:
Senzanome

after: fixed!

@Dream-Master Dream-Master requested a review from a team October 6, 2024 19:09
@Fabboz
Copy link
Author

Fabboz commented Oct 6, 2024

i can't do better than that

Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legally we can't allow this, it's a great way for us to get cease and desisted

@Fabboz
Copy link
Author

Fabboz commented Oct 6, 2024

i'm not a programmer. I would be happy if someone made these changes for me. Thank you

@Fabboz
Copy link
Author

Fabboz commented Oct 6, 2024

And i found that is automagy that made that bug with botania and bloodmagic and waila. also hiding waila fix it.

@Fabboz
Copy link
Author

Fabboz commented Oct 19, 2024

i'm sorry i don't know how to run spotlessapply in my workspace sorry

@lordIcocain
Copy link

./gradlew build spotlessApply
in terminal

@Fabboz Fabboz closed this Oct 19, 2024
@Dream-Master
Copy link
Member

@Fabboz wh you close this ?

@Fabboz
Copy link
Author

Fabboz commented Oct 19, 2024

@Fabboz wh you close this ?

I cant make the changes requested

@Dream-Master Dream-Master reopened this Oct 20, 2024
@Dream-Master
Copy link
Member

@Fabboz i did it for you
update dependencies as well

@Dream-Master Dream-Master requested review from a team, OneEyeMaker and Alastors October 20, 2024 09:36
@chochem
Copy link
Member

chochem commented Oct 20, 2024

if they used ARR code then we cant use this, Dream

@Dream-Master
Copy link
Member

@chochem ARR code ? its just some render code changes? Or i am wrong ?

@chochem
Copy link
Member

chochem commented Oct 20, 2024

which they say they took from thaumcraft

@Dream-Master
Copy link
Member

which they say they took from thaumcraft

even if people can use code fragments to improve other code? I don't see a problem here. Should I call a lawyer? :trollface:

@Fabboz
Copy link
Author

Fabboz commented Oct 20, 2024

@Fabboz i did it for you update dependencies as well

thx.

it's not a copy paste.

@boubou19
Copy link
Member

Nothing thaumcraft related in there, it's base OGL manipulation.

@chochem
Copy link
Member

chochem commented Oct 20, 2024

they literally say so in the description boubou

@boubou19 boubou19 merged commit 222ad16 into GTNewHorizons:master Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants