fix incorrect url generation for artifacts containing a whitespace #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boubou19
approved these changes
May 13, 2024
Dream-Master
approved these changes
May 13, 2024
…semblerXXL into fix/thaumicmachina
boubou19
added a commit
that referenced
this pull request
May 13, 2024
* Fix grammar + formatting of changelog credits * update * update * update angelica * Upload changelog from nightly 469 to 470 * include external mod in the differential update * fix incorrect url generation for artifacts containing a whitespace (#158) * fix incorrect url generation for artifacts containing a whitespace * apparently our download server uses %20 instead of + * include external mod in the differential update * fix incorrect url generation for artifacts containing a whitespace * apparently our download server uses %20 instead of + --------- Co-authored-by: boubou19 <miisterunknown@gmail.com> * Fix grammar + formatting of changelog credits --------- Co-authored-by: Martin Robertz <dream-master@gmx.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boubou19 <miisterunknown@gmail.com> Co-authored-by: Glease <4586901+Glease@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: https://discord.com/channels/181078474394566657/939305179524792340/1239515648531628053