Use Tags.GROUPNAME for MyMod proxy #193
Conversation
| @@ -15,7 +15,7 @@ public class MyMod { | |||
|
|
|||
| public static final Logger LOG = LogManager.getLogger(Tags.MODID); | |||
|
|
|||
| @SidedProxy(clientSide = "com.myname.mymodid.ClientProxy", serverSide = "com.myname.mymodid.CommonProxy") | |||
| @SidedProxy(clientSide = Tags.GROUPNAME + ".ClientProxy", serverSide = Tags.GROUPNAME + ".CommonProxy") | |||
There was a problem hiding this comment.
I think this is one of the things that shouldn't be parametrised, to allow changing maven coordinates without having to modify mod sources (in this case moving all java files to a different package).
There was a problem hiding this comment.
Is it that common case than starting new project? My intention is to reduce confusion for newcomers
There was a problem hiding this comment.
Group, modname and modid shouldn't even be tokenized (if that's a word) in my opinion, as those should never change. Tieing them to properties in gradle.properties feels very counterproductive. (If you need to change one of those for whatever reason you should know what you're doing regardless.)
My intention is to reduce confusion for newcomers
Newcomers should idealy read/watch a tutorial first. They nearly always explain how to use @SidedProxy when setting up the main mod class. Kinda unrelated to this PR but still: giving a newcomer this template removes the need to understand what they are doing, resulting in possibly poorer code quality and/or redundant code and/or more bugs in the long run.
Also remove outdated script