Use normal jar for runClient/runServer #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embeddedt
added a commit
to GTNewHorizons/Angelica
that referenced
this pull request
Dec 24, 2023
Will be fixed upstream in GTNewHorizons/ExampleMod1.7.10#244
mitchej123
pushed a commit
to GTNewHorizons/Angelica
that referenced
this pull request
Dec 25, 2023
Will be fixed upstream in GTNewHorizons/ExampleMod1.7.10#244
eigenraven
reviewed
Jan 1, 2024
| @@ -959,22 +959,13 @@ if (usesShadowedDependencies.toBoolean()) { | |||
| configurations.apiElements.outgoing.artifacts.clear() | |||
| configurations.runtimeElements.outgoing.artifact(tasks.named("shadowJar", ShadowJar)) | |||
| configurations.apiElements.outgoing.artifact(tasks.named("shadowJar", ShadowJar)) | |||
| tasks.named("jar", Jar) { | |||
| enabled = false | |||
There was a problem hiding this comment.
This task has to stay disabled, or at least needs to be reconfigured to a different classifier like -dev-preshadow when shadow is enabled, otherwise you have 2 gradle tasks producing the same jar: mod-dev.jar when shadow is enabled. This can lead to issues with confused jars, or gradle erroring out if both tasks try to be run at build time.
eigenraven
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring
runClientto depend onshadowJarmeans that shadowing must be run every time a change is made while developing a mod. For mods with a lot of shadowed dependencies (e.g. Angelica), this is painfully slow.It shouldn't be necessary to do this as the dependencies are accessible in dev already. Shadowing is only needed at reobf time, and still works there after the change in this PR.