Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note that jabel may cause issues sometimes #258

Closed
wants to merge 4 commits into from
Closed

Conversation

bombcar
Copy link
Member

@bombcar bombcar commented Jan 22, 2024

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik Jabel only breaks things when compiling Scala code

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh, I'd rather have the bs automatically disable Jabel if scala is detected. Then a simple note ("This property is automatically disabled when using Scala") should be enough.

@bombcar
Copy link
Member Author

bombcar commented Jan 22, 2024

Tbh, I'd rather have the bs automatically disable Jabel if scala is detected. Then a simple note ("This property is automatically disabled when using Scala") should be enough.

That's a much better option, but I don't know how to modify the buildscript to do that. If someone wants to they can delete this change.

@boubou19
Copy link
Member

@glowredman @mitchej123 @eigenraven any plan to automagically disable jabel if compiling scala or should this be merged as is?

@eigenraven
Copy link
Member

Will fix in GTNHGradle

@eigenraven eigenraven closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants