Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dynamic Adjustment logic and instead apply the adjustment right away if a fuel is eligible for super eff increase #3062

Merged
merged 11 commits into from
Sep 9, 2024

Conversation

spacebuilder2020
Copy link
Contributor

@spacebuilder2020 spacebuilder2020 commented Sep 5, 2024

This is intentionally behind master by one commit since something in the most recent commit is causing a infinite loop when loading Iguana Tweaks.

See discord for the reasoning behind this change.

…t away if a fuel is eligible for super eff increase.
@spacebuilder2020
Copy link
Contributor Author

I am leaving this in draft state until the issue with #3050 is resolved and once that is done I will retest with a updated branch.

@boubou19 boubou19 added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Sep 5, 2024
@Dream-Master Dream-Master requested a review from a team September 6, 2024 10:13
@spacebuilder2020
Copy link
Contributor Author

Seems like the crash is still happening on the most recent merge, however it is a slightly different one.
Going to go ahead and remove this PR from draft since there isn't really much I can do about this crash.
fml-client-latest.log

@spacebuilder2020 spacebuilder2020 marked this pull request as ready for review September 6, 2024 11:24
@Dream-Master
Copy link
Member

@spacebuilder2020 vexatos make a new build maybe that work

@spacebuilder2020
Copy link
Contributor Author

spacebuilder2020 commented Sep 6, 2024

alright, I will try that one.

edit: I am testing on nightly 629 and it looks like build 1.0.30 (the latest one) is the build that is in use.

@spacebuilder2020
Copy link
Contributor Author

spacebuilder2020 commented Sep 6, 2024

I just tested 5.09.49.71-pre with nightly 629 and it also had the same crash.
fml-client-latest.log

This is on the latest Tgregworks release

@spacebuilder2020
Copy link
Contributor Author

spacebuilder2020 commented Sep 7, 2024

Screen.Recording.2024-09-07.062229.mp4

Tested and working with most recent merge.

@spacebuilder2020
Copy link
Contributor Author

Btw, I feel it is important to note that this is also a bug fix since the previous PR introduced a bug while I was sleeping.
6051436

By changing the logic from less than to less than or equal, it caused the adjustment logic to get called endlessly until such point it overflowed.

@boubou19 boubou19 enabled auto-merge (squash) September 9, 2024 00:22
@boubou19 boubou19 merged commit e37dd40 into GTNewHorizons:master Sep 9, 2024
5 checks passed
miozune pushed a commit that referenced this pull request Sep 14, 2024
…t away if a fuel is eligible for super eff increase (#3062)

Co-authored-by: Martin Robertz <dream-master@gmx.net>
Co-authored-by: boubou19 <miisterunknown@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants