-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Dynamic Adjustment logic and instead apply the adjustment right away if a fuel is eligible for super eff increase #3062
Conversation
…t away if a fuel is eligible for super eff increase.
I am leaving this in draft state until the issue with #3050 is resolved and once that is done I will retest with a updated branch. |
Seems like the crash is still happening on the most recent merge, however it is a slightly different one. |
@spacebuilder2020 vexatos make a new build maybe that work |
alright, I will try that one. edit: I am testing on nightly 629 and it looks like build 1.0.30 (the latest one) is the build that is in use. |
I just tested 5.09.49.71-pre with nightly 629 and it also had the same crash. This is on the latest Tgregworks release |
Screen.Recording.2024-09-07.062229.mp4Tested and working with most recent merge. |
Btw, I feel it is important to note that this is also a bug fix since the previous PR introduced a bug while I was sleeping. By changing the logic from less than to less than or equal, it caused the adjustment logic to get called endlessly until such point it overflowed. |
…t away if a fuel is eligible for super eff increase (#3062) Co-authored-by: Martin Robertz <dream-master@gmx.net> Co-authored-by: boubou19 <miisterunknown@gmail.com>
This is intentionally behind master by one commit since something in the most recent commit is causing a infinite loop when loading Iguana Tweaks.
See discord for the reasoning behind this change.