Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Laser & Data pipe every 32 tick connection update #3259

Merged
merged 22 commits into from
Oct 3, 2024

Conversation

dagger8243
Copy link
Contributor

Before laser pipes were a major lag source cause every 32 ticks they would cause a connection check, now its just on coloring pipe, on block break and on server start

@FourIsTheNumber
Copy link
Contributor

If this fix works it should be applied to data pipes as well 🥺

@FourIsTheNumber FourIsTheNumber added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Sep 22, 2024
@dagger8243
Copy link
Contributor Author

uh sure, let me check how hard it would be to do same over there

@Dream-Master
Copy link
Member

Dream-Master commented Sep 23, 2024

@dagger8243 please run spotless done

@Dream-Master Dream-Master requested a review from a team September 23, 2024 19:14
@OneEyeMaker
Copy link
Contributor

This update logic should be also called on neighbor block update (when you extend your network), shouldn't it?

@Dream-Master
Copy link
Member

@dagger8243

@dagger8243 dagger8243 changed the title Fixed Laser pipe every 32 tick connection update Fixed Laser & Data pipe every 32 tick connection update Sep 29, 2024
Copy link
Contributor

@TheEpicGamer274 TheEpicGamer274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@dagger8243
Copy link
Contributor Author

This update logic should be also called on neighbor block update (when you extend your network), shouldn't it?

ye, its doing that, also making sure it doesnt cascade creating lag spikes

Lyfts
Lyfts previously requested changes Sep 30, 2024
Copy link
Member

@Lyfts Lyfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not updating correctly if you place and paint a hatch after the pipe has been painted
gt_hatch
And it will stay connected if you break the hatch
gt_hatch2

@Dream-Master
Copy link
Member

@dagger8243

@Dream-Master
Copy link
Member

@Lyfts pr ok now ?

@dagger8243
Copy link
Contributor Author

no i gotta fix the server sided animation system cause packets a massive source of lag apparently

@Dream-Master Dream-Master enabled auto-merge (squash) October 2, 2024 19:54
@Dream-Master
Copy link
Member

@dagger8243 any news? need this pr more work ?

@dagger8243
Copy link
Contributor Author

everything is working, boubou lyft and i discussed the packet thing and decided it aint as major of a concern as i thought, if its needed i can make another pr dealing with it

@Dream-Master Dream-Master enabled auto-merge (squash) October 3, 2024 06:03
@Dream-Master Dream-Master merged commit ac992c3 into GTNewHorizons:master Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants