-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Laser & Data pipe every 32 tick connection update #3259
Conversation
If this fix works it should be applied to data pipes as well 🥺 |
uh sure, let me check how hard it would be to do same over there |
|
This update logic should be also called on neighbor block update (when you extend your network), shouldn't it? |
src/main/java/tectech/thing/metaTileEntity/pipe/MTEPipeData.java
Outdated
Show resolved
Hide resolved
src/main/java/tectech/thing/metaTileEntity/pipe/MTEPipeData.java
Outdated
Show resolved
Hide resolved
src/main/java/tectech/thing/metaTileEntity/pipe/MTEPipeData.java
Outdated
Show resolved
Hide resolved
src/main/java/tectech/thing/metaTileEntity/pipe/MTEPipeEnergy.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
ye, its doing that, also making sure it doesnt cascade creating lag spikes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lyfts pr ok now ? |
no i gotta fix the server sided animation system cause packets a massive source of lag apparently |
@dagger8243 any news? need this pr more work ? |
everything is working, boubou lyft and i discussed the packet thing and decided it aint as major of a concern as i thought, if its needed i can make another pr dealing with it |
Before laser pipes were a major lag source cause every 32 ticks they would cause a connection check, now its just on coloring pipe, on block break and on server start