Remove duplicate materials from gt++ #3268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GT++ generates duplicate versions of many materials from bartworks and gregtech for use in its material system. This pr removes component generation for these materials. I tested this in 2.7 beta-1 and it does not crash or return null recipes in the log - let me know if there's additional testing I need to do.
NOTES:
-GT++ was already de-prioritized in oredict, so the removed materials were all ones which would transform into gt/bartworks versions in inventory. This means it should not affect existing items or patterns
-This does not remove GT++ material registration itself, so the materials work the same in all cases where used, it is just not generating the dust/plate/ingot/etc (and in recipes will use the oredicted alternatives)
-This does not remove GT++ plasmas, which are registered separately (relevant to gorge especially)
-"Unusual" components like zirconium fine wire were also registered separately, so the GT++ version of this still exists (and is used in a recipe)
-By removing rhodium/ruthenium from GT++, ores which used to give pure versions of these elements no longer skip the platinum sludge loader. This means that ~3 GT++ ores now give crude rhodium or leach residue instead of pure elements
-I blacklisted milling recipes so that they can keep this functionality, since there are few of those recipes and they are manually instantiated. These still give pure elements as they did originally
-Praesodymium dust in ebf has changed slightly because the original gt recipe was previously losing the collision war. Now it is a longer recipe and does not give a hot ingot
-I modified GT's strontium to generate metalworking items since GT++ version did previously. No idea if any of these are used, but now they are part of the GT material