Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate materials from gt++ #3268

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Conversation

FourIsTheNumber
Copy link
Contributor

@FourIsTheNumber FourIsTheNumber commented Sep 23, 2024

GT++ generates duplicate versions of many materials from bartworks and gregtech for use in its material system. This pr removes component generation for these materials. I tested this in 2.7 beta-1 and it does not crash or return null recipes in the log - let me know if there's additional testing I need to do.

NOTES:
-GT++ was already de-prioritized in oredict, so the removed materials were all ones which would transform into gt/bartworks versions in inventory. This means it should not affect existing items or patterns
-This does not remove GT++ material registration itself, so the materials work the same in all cases where used, it is just not generating the dust/plate/ingot/etc (and in recipes will use the oredicted alternatives)
-This does not remove GT++ plasmas, which are registered separately (relevant to gorge especially)
-"Unusual" components like zirconium fine wire were also registered separately, so the GT++ version of this still exists (and is used in a recipe)
-By removing rhodium/ruthenium from GT++, ores which used to give pure versions of these elements no longer skip the platinum sludge loader. This means that ~3 GT++ ores now give crude rhodium or leach residue instead of pure elements
-I blacklisted milling recipes so that they can keep this functionality, since there are few of those recipes and they are manually instantiated. These still give pure elements as they did originally
-Praesodymium dust in ebf has changed slightly because the original gt recipe was previously losing the collision war. Now it is a longer recipe and does not give a hot ingot
-I modified GT's strontium to generate metalworking items since GT++ version did previously. No idea if any of these are used, but now they are part of the GT material

@FourIsTheNumber FourIsTheNumber added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Sep 23, 2024
@boubou19 boubou19 enabled auto-merge (squash) September 23, 2024 21:44
@boubou19 boubou19 merged commit ec16529 into master Sep 23, 2024
5 checks passed
@boubou19 boubou19 deleted the remove-duplicate-materials branch September 23, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants