Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cactus/Sugar Charcoal/Coke Blocks #3269

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

Cleptomania
Copy link
Member

This adds new blocks for the Cactus and Sugar charcoal/coke items roughly in line with the suggestion from GTNewHorizons/GT-New-Horizons-Modpack#15845.

image

The blocks follow the same logic as the compressed charcoal/coal blocks from New Horizons Core Mod. You get an extra charcoal/coke from the initial compression into a block, and then the further compressed variants are just more dense, but don't give extra efficiency.

The texture for these blocks are essentially recolored versions of the compressed charcoal/coke blocks from New Horizons Core Mod. If there is a desire to, someone could re-do the textures, but I am no artist.

This also adds recipes for the base coke blocks(non compressed) to be used in the primitive blast furnace, at a rate of double the coal requirement, the charcoal blocks cannot be used in the blast furnace. So where smelting 10 steel ingots from iron ingots would take 4 coal blocks, it will take 8 sugar/cactus coke blocks. These recipes produce full pieces of ash, meaning using the blocks will allow the blast furnace to fill with steel, before it fills with ashes, similar to the benefit of using charcoal/coal blocks. These recipes are dynamically generated.

@Cleptomania Cleptomania added Affects Balance Change affecting balance. Requires admin approval before merging. new feature Add something new. Please explain in detail how it works. labels Sep 24, 2024
@Dream-Master Dream-Master requested a review from a team September 24, 2024 06:00
@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Sep 24, 2024
@Dream-Master
Copy link
Member

@chochem this are just blocks we can add it for 2.7.0. i see no issues here

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Sep 24, 2024
@Cleptomania
Copy link
Member Author

@Dream-Master Are you happy with the blast furnace recipes? I forgot to mention in the original PR that they are faster than the coal/charcoal versions. They run at the same duration that the coal coke recipes do, so they're faster than using coal/charcoal, but require double the fuel. I think that's fine because you also have two coke oven steps to actually get the sugar/cactus coke, similar to making normal coal coke.

@Cleptomania
Copy link
Member Author

I added images of an example of the cactus coke recipe vs the coal block recipe here, it does follow the same math as the sugar/cactus coke single items, just multiplied for the blocks

image
image

@Dream-Master Dream-Master enabled auto-merge (squash) September 24, 2024 17:50
@Dream-Master Dream-Master merged commit c3c5780 into master Sep 24, 2024
5 checks passed
@Dream-Master Dream-Master deleted the cactus-sugar-burnables branch September 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Change affecting balance. Requires admin approval before merging. new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants