Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Heat Exchanger interaction with Stocking Input Hatch(ME) #3271

Merged

Conversation

reobf
Copy link
Contributor

@reobf reobf commented Sep 24, 2024

Sorry! Forgot to run spotlessApply before pull request

This PR tries to fix two problems.

  1. Heat Exchanger(all 3 varients) hotfluid Input Hatch position does not support Stocking Input Hatch(ME)

GTNewHorizons/GT-New-Horizons-Modpack#17419

  1. Heat Exchanger(only Adv and Extreme ver.) distilledwater Input Hatch position works with Stocking Input Hatch(ME), but with weird behaviour(x20 times the output steam)

GTNewHorizons/GT-New-Horizons-Modpack#16954

This PR add missing 'startRecipeProcessing' & 'endRecipeProcessing' method calls
and make Stocking Input Hatch(ME) work properly with Heat Exchanger.

figure : Heat Exchangers running with Stocking Input Hatch(ME)
Heat Exchanger will say ‘No Recipe Found’ before fix.


figure : Extreme Heat Exchangers before and after fix
the steam amount is correct before and after fix,but before fix distilledwater consumption is divided by 20 for unknown reason


@Dream-Master Dream-Master requested a review from a team September 24, 2024 17:02
@Dream-Master Dream-Master added the bug fix Fix a bug. Please link it in the PR. label Sep 24, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) September 26, 2024 15:14
@Dream-Master Dream-Master merged commit 302a698 into GTNewHorizons:master Sep 26, 2024
5 checks passed
@reobf reobf deleted the fix-heat-exchanger-fluid-input branch September 27, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants