Fix BaseMetaPipeEntity pass wrong side argument to 'onPlayerAttach' #3288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument passed to 'onPlayerAttach' is the clicked side('side'), not the wrenching side('coverSide'), 'onPlayerAttach' will receive wrong argument if attaching cover when sneaking.
This bug has no bad effects for now, because most 'onPlayerAttach' is a no-op for most covers.
And the only one CoverBehavour that overrides 'onPlayerAttach' is metrics cover, which is not allowed to be attched to BaseMetaPipeEntity.
But I think this will help if some CoverBehavour overrides onPlayerAttach in the future.
compare to BaseMetaTileEntity which is implemented correctly:
GT5-Unofficial/src/main/java/gregtech/api/metatileentity/BaseMetaTileEntity.java
Lines 1680 to 1683 in e9fe2d8
GT5-Unofficial/src/main/java/gregtech/api/metatileentity/BaseMetaPipeEntity.java
Lines 961 to 964 in e9fe2d8