Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify machine sound loop to use SoundResource #3289

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Unify machine sound loop to use SoundResource #3289

merged 2 commits into from
Sep 28, 2024

Conversation

miozune
Copy link
Member

@miozune miozune commented Sep 27, 2024

  • We can consolidate sounds from addons at SoundResource without resorting to ResourceLocation
  • TT SoundLoop precedes GTSoundLoop, but anyways
  • Add sound id collision check

@miozune miozune added the refactor For PRs rewritting a part of the code to have a nicer code overall. label Sep 27, 2024
@miozune miozune requested a review from a team September 27, 2024 14:03
@boubou19 boubou19 enabled auto-merge (squash) September 28, 2024 11:10
@boubou19 boubou19 merged commit 6b1f145 into master Sep 28, 2024
5 checks passed
@boubou19 boubou19 deleted the refactor/unify-sound-loop branch September 28, 2024 11:16
@Alexdoru Alexdoru mentioned this pull request Oct 8, 2024
Merged
@FireWarrior2 FireWarrior2 mentioned this pull request Oct 17, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boubou19 boubou19 boubou19 approved these changes

Assignees
No one assigned
Labels
refactor For PRs rewritting a part of the code to have a nicer code overall.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miozune @boubou19