Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give ore mixes localized names #3290

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Give ore mixes localized names #3290

merged 4 commits into from
Sep 28, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Sep 27, 2024

Makes it possible to give ore mixes names based on localized material names so that VP & GTNEIOre don't have to invent their own names. There's no point in localizing the same thing across multiple files in multiple mods.

BW ores are not included in this but GTNEIOre doesn't support them anyways and I've got a solution for VP there.

@Lyfts Lyfts requested a review from a team September 27, 2024 15:26
@Dream-Master Dream-Master added bug fix Fix a bug. Please link it in the PR. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. labels Sep 27, 2024
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Garnet/Tin is potentially the most important one to localize. can you bring that back?

@Lyfts
Copy link
Member Author

Lyfts commented Sep 27, 2024

Shit, we could even stop confusing new players and just localize that one as "Tin"

@Lyfts
Copy link
Member Author

Lyfts commented Sep 27, 2024

Alright, I went ahead and did just that. For reference as to why one can search for "Garnettin" in #help

@chochem
Copy link
Member

chochem commented Sep 27, 2024

might need a quest adjustment but yea that sounds good (assuming none of the other is called tin :P)

@boubou19 boubou19 enabled auto-merge (squash) September 28, 2024 11:30
@boubou19 boubou19 merged commit e08a304 into master Sep 28, 2024
5 checks passed
@boubou19 boubou19 deleted the localized-oremixes branch September 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fix a bug. Please link it in the PR. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants