Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: GTNewHorizons/GT-New-Horizons-Modpack#16565
The bug is: Charge a GT++ Energy Buffer to full energy, save the game and load it again, there will be ERROR in log:
expand
This happens if:
internal EU value might exceed the maximum, but 'aStoredEU' is strictly truncated to max EU storage
That's why the bug only happens when its chraged to full energy
This PR removes unnecessary saving of 'aStoredEU' in method 'saveNBTData', to prevent accessing 'worldObj' too early.
After fix, Energy Buffer will not lose its energy after save-n-load because internal EU value is already persisted in BaseMetaTileEntity.java.
GT5-Unofficial/src/main/java/gregtech/api/metatileentity/BaseMetaTileEntity.java
Line 145 in 96f2d08
GT5-Unofficial/src/main/java/gregtech/api/metatileentity/BaseMetaTileEntity.java
Line 189 in 96f2d08
The function of keeping EU after harvested won't be affected, because 'loadNBTData' and 'setItemNBT' will still work.