Fix advanced mufflers in the XLGT and other multiblocks with >1 muffler hatch #3489
+12
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em randomly and equally instead of arbitrarily choosing one. This results in obtaining (on average) the average pollution reduction of all hatches if they are different tiers; in addition all advanced muffler hatches will pull and damage air filters. Pollution reported by getInfoData() has been updated to reflect this.
…TurbineBase. Fixes #17953.
|
Tested on HEAD -- I built a handful of multiblocks: EBF, XLGT and UFCE, they all seem to work correctly. |
FourIsTheNumber
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GTNewHorizons/GT-New-Horizons-Modpack#17953.
With this change, multiblocks with >1 muffler hatch vent pollution evenly through all of them, selecting a different one at random each time. Also, the XLGT now correctly pulls air filters from input buses if you used advanced muffler hatches with it.