Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GT Assembler recipes for Muffler Upgrades #3498

Merged

Conversation

HFPTetraUro
Copy link
Contributor

@HFPTetraUro HFPTetraUro commented Nov 14, 2024

Currently, Muffler Upgrades have 6 recipe variants which are a combination of one of 3 plates and one of 2 dusts, but they all give the same result despite some variants being more expensive. The table below shows the previous recipes and the changes made, the balancing has been done based on how hard to get each material is.

Plate Material Dust Material Original Output Original Duration New Output New Duration
Aluminium Plastic 1 1 minute, 20 seconds 4 1 minute, 20 seconds
Aluminium Wood 1 1 minute, 20 seconds 2 1 minute
Wrought Iron Plastic 1 1 minute, 20 seconds 2 1 minute, 20 seconds
Wrought Iron Wood 1 1 minute, 20 seconds 1 1 minute
Iron Plastic 1 1 minute, 20 seconds 1 1 minute
Iron Wood 1 1 minute, 20 seconds 1 1 minute, 20 seconds

Edit:
Just remove all the recipes and leave the cheapest one with an updated recipe time to be faster. After all the muffler upgrade is a quality of life upgrade and the item isn't used in crafting anywhere else there is no point to have multiple recipe variants that give increasingly more.

@Dream-Master Dream-Master requested a review from a team November 14, 2024 23:01
@Alexdoru
Copy link
Member

Pesronally I would of deleted all the recipes and kept the less expensive one only. This is not an item that you need in large quantities, there is no reason to have different recipes that increasingly become better.

@Alexdoru Alexdoru added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Nov 14, 2024
@HFPTetraUro
Copy link
Contributor Author

I agree with you that there are too many variants, but I do think the lowest cost recipe takes too long to make early game, and you would want dozens of it if you make setups with many machines, so I think there should be at least another variant which is faster/better yield. I just used the existing useless more expensive recipe variants for that.

@Alexdoru
Copy link
Member

I agree with you that there are too many variants, but I do think the lowest cost recipe takes too long to make early game, and you would want dozens of it if you make setups with many machines, so I think there should be at least another variant which is faster/better yield. I just used the existing useless more expensive recipe variants for that.

You're right the recipe takes too long, what about you keep only this one and make it 5 sec 30eu/t ?
image

@HFPTetraUro
Copy link
Contributor Author

I agree with you that there are too many variants, but I do think the lowest cost recipe takes too long to make early game, and you would want dozens of it if you make setups with many machines, so I think there should be at least another variant which is faster/better yield. I just used the existing useless more expensive recipe variants for that.

You're right the recipe takes too long, what about you keep only this one and make it 5 sec 30eu/t ? image

That sounds fair. I'll commit tomorrow and run spotless too

Copy link
Contributor

@Ethryan Ethryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 15, 2024
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes are fully at odds with the pr description and title

@Ethryan
Copy link
Contributor

Ethryan commented Nov 15, 2024

the changes are fully at odds with the pr description and title

Maybe, but its the result of the discussion in here, and the title and description can always be changed.

@chochem
Copy link
Member

chochem commented Nov 15, 2024

yea I am saying they should be changed when the PR does something entirely different.

@Ethryan
Copy link
Contributor

Ethryan commented Nov 15, 2024

Fair Point.

@HFPTetraUro , Please update the Title and Description to match the effects of this pull request.

@Alexdoru Alexdoru changed the title Re-balance GT Assembler recipes for Muffler Upgrades Simplify GT Assembler recipes for Muffler Upgrades Nov 15, 2024
@Alexdoru
Copy link
Member

I edited the pr title and text

@Alexdoru Alexdoru removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 15, 2024
@Alexdoru Alexdoru merged commit 47b803c into GTNewHorizons:master Nov 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants