This repository has been archived by the owner on May 26, 2024. It is now read-only.
Add Wireless Charger Baubles Compat #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alastors
approved these changes
Jun 26, 2023
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
miozune
reviewed
Jun 27, 2023
There was a problem hiding this comment.
I find logic for charging items suspicious:nvm, it seems to be penalty for distancechargeItemsExdirectly reduces energy stored in the tile, but thenmStartingEu - mCurrentEu <= 0section reduces energy depending on distance. I think the latter code can be removed.- Annotate
mEntityinchargeItemsandchargeItemsExto be non-null
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
miozune
reviewed
Jun 27, 2023
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
miozune
reviewed
Jun 27, 2023
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/xmod/gregtech/common/helpers/ChargingHelper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes wireless charger be able to charge items in bauble slots. Also integrated some suggestions from intelliJ to reduce number of warnings in the class.