This repository has been archived by the owner on May 26, 2024. It is now read-only.
Make PSS stop pulling input power when it's full. #687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PSS voids 1% of stored power whenever it fills up, which causes it to always draw power as quickly as it can. This is caused by a missing check in
drawEnergyFromHatch
, which charges the PSS over its capacity, which then triggers the overcharge check inonRunningTick
. This change prevents the PSS from pulling power if it would cause it to overcharge.