This repository has been archived by the owner on May 26, 2024. It is now read-only.
Clean up BOP_block_Registrator and convert it to RA2 #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueWeabo
reviewed
Oct 12, 2023
Comment on lines
+128
to
+135
| GT_Values.RA.stdBuilder().itemInputs(new ItemStack(aStack.getItem(), 1, i)) | ||
| .itemOutputs( | ||
| GT_Utility.copyAmount( | ||
| GT_Mod.gregtechproxy.mNerfedWoodPlank ? ((long) tStack.stackSize) | ||
| : (((long) tStack.stackSize) * 5L / 4), | ||
| tStack), | ||
| GT_OreDictUnificator.get(OrePrefixes.dust, Materials.Wood, 2L)) | ||
| .duration(10 * SECONDS).eut(8).addTo(sCutterRecipes); |
There was a problem hiding this comment.
Should this have no fluid input? Wasn't this water? Because otherwise the machines could sometimes just do this recipes instead of the one with lubricant
There was a problem hiding this comment.
I just ra2ed that part :P
no fluid should generate the 3 water/distilled/lubricant recipes (its the rare case where RA2 is not explicit).
but that begs the question what the lubricant one is for. will remove that one
Comment on lines
+161
to
+168
| GT_Values.RA.stdBuilder().itemInputs(GT_Utility.copyAmount(1L, aStack)) | ||
| .itemOutputs( | ||
| GT_Utility.copyAmount( | ||
| GT_Mod.gregtechproxy.mNerfedWoodPlank ? ((long) tStack2.stackSize) | ||
| : (((long) tStack2.stackSize) * 5L / 4), | ||
| tStack2), | ||
| GT_OreDictUnificator.get(OrePrefixes.dust, Materials.Wood, 2L)) | ||
| .duration(10 * SECONDS).eut(8).addTo(sCutterRecipes); |
There was a problem hiding this comment.
Same as above. Shouldn't water be an input?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small cleanup with RA2 conversion.