Let remainingFlow become 125% of realOptFlow, rather than raw optimal… #841
Conversation
… flow. This can fix the inconsistance between optimal flow in tooltip and that in turbine.
|
tooltip of duranium huge turbine |
|
Scanner result shows the optimal flow is 4915200mb/t. |
… generate power greater than Integer.MAX_VALUE on SC Turbine.
|
Data of ichorium |
| int tEU = 0; | ||
| int totalFlow = 0; // Byproducts are based on actual flow | ||
| int flow = 0; | ||
| int remainingFlow = MathUtils.safeInt((long) (aOptFlow * 1.25f)); // Allowed to use up to 125% of optimal flow. | ||
| // Variable required outside of loop for | ||
| // Variable required outside of loop for | ||
| // multi-hatch scenarios. | ||
| this.realOptFlow = (double) aOptFlow * (double) flowMultipliers[0]; |
There was a problem hiding this comment.
I think this was just here from a copy paste error or something like that.
SC does not (!) use flowmultipliers. see https://github.com/GTNewHorizons/GoodGenerator/blob/master/src/main/java/goodgenerator/blocks/tileEntity/SupercriticalFluidTurbine.java
There was a problem hiding this comment.
Well, I don't know what original author thought, maybe we can fix that together.
There was a problem hiding this comment.
And if necessery we can add a new multiplier to SC steam for turbines.
There was a problem hiding this comment.
we can talk with some more devs. But I dont think we want to buff SC steam. its already the meta for plasma.
There was a problem hiding this comment.
thanks! a material specific multiplier for SC will have to wait I think until someone really wants go into balancing SC as a whole. (steelux agreed with me on discord)
I made a PR to add SC to the tooltip so it is clear to the player.
There was a problem hiding this comment.
Tooltip is really misleading, I wasted a whole day build fusions for duranium :(
There was a problem hiding this comment.
...tech/common/tileentities/machines/multi/production/turbines/GT_MTE_LargeTurbine_SCSteam.java
Show resolved
Hide resolved
… flow.
This can fix the inconsistance between optimal flow in tooltip and that in turbine.
When I try to use duranium huge turbine on my XL SC Turbine, I found that the actual output and steam consumption is far less than the calculation.
XL SC turbine outputs 6768000EU/t on server, but according to calculation, output is parallelism * optimal flow * efficiency% * fuel value of SC steam. The optimal flow in XL SC turbine with duranium huge turbine inserted and fast mode enabled is 48 * single optimal flow = 4915200mb/t. The turbine efficiency is 235%, and fuel value of SC steam is 100EU/mb. So final output should be 4915200 * 2.35 * 100 = 115507200 EU/t. Obviously it doesn't work as the description on turbine tooltip.
Through reading the code I found that 6768000 = 6400 * 1.25 * 2.35 * 100 * 48 * 0.75 (effiency when flow over optimal).
While 6400 is the original optimal flow of the turbine, and has different multipliers when used in different type of machine.
I found that the variable realOptFlow uses that multiplier but remainingFlow doesn't, so the optimal flow is limited to original flow, rather than actual flow. Through this change I let the steam/HP/SC turbine behave as tooltip on turbine describes.
Output of SC turbine with duranium huge turbine after fix:
