Skip to content
This repository has been archived by the owner on May 26, 2024. It is now read-only.

Cleaning! #881

Merged
merged 29 commits into from
May 22, 2024
Merged

Cleaning! #881

merged 29 commits into from
May 22, 2024

Conversation

Connor-Colenso
Copy link
Contributor

  • Remove a ton of unused textures (some double checking on this would be helpful, nothing obvious in NEI).
  • Removed debug scanner, doesn't seem to do anything useful.
  • Changed name of mobessence to Mob Essence.
  • Removed xpjuice fluid (this is some useless GT++ variant as far as I can tell).
  • Clean up a bunch of configs.
  • Clean up tooltips and remove some old ones.
  • Remove sick blazes, I couldn't even get these to spawn?

Other misc stuff as well but those are the main points I think

Copy link
Contributor

Warning: 2 uncommitted changes
#882

@Dream-Master
Copy link
Member

@Connor-Colenso did you add back fluorine ? Was removed with the last cleanup . Gt++ had a own xp recipe not sure this is vanished when you remove the xp fluid ?

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. already discussed on discord, but just to put it here too: the blazes work perfectly fine. both the egg and natural spawns. please revert that part.
  2. see comment about xp conversion recipes

for the textures I am not sure how best to check either, maybe there is something in the start-up log if one of the textures is now missing for something.

@chochem
Copy link
Member

chochem commented May 15, 2024

@Connor-Colenso did you add back fluorine ? Was removed with the last cleanup . Gt++ had a own xp recipe not sure this is vanished when you remove the xp fluid ?

the xpjuice is added by openblocks and still will be after this. this was just a fallback for when openblocks is missing.

Copy link
Contributor

Warning: 2 uncommitted changes
#883

@Connor-Colenso
Copy link
Contributor Author

The sick blazes are back, although they do nothing. @chochem

Copy link
Contributor

Warning: 2 uncommitted changes
#884

spotlessApply

Co-authored-by: GitHub GTNH Actions <>
@chochem chochem dismissed their stale review May 22, 2024 17:00

was done though I dont understand the comment.

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nobody else found any issues, so lets go with it.

@Dream-Master Dream-Master merged commit 23494ad into master May 22, 2024
1 check passed
@Dream-Master Dream-Master deleted the Cleaning! branch May 22, 2024 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants