Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback string for close window dialog #1087

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

wlhlm
Copy link
Member

@wlhlm wlhlm commented Nov 19, 2024

When FML encounters an error, the only way to quit the game is through the close button. This will show a "are you sure" dialog. Unfortunately, the dialog will show no message as locales have not been loaded yet at this stage. This adds a fallback message in English (same locale as the FML error).

Fixes the following:
GTNH close window bug

@wlhlm wlhlm requested a review from Alexdoru November 19, 2024 19:57
@Dream-Master Dream-Master enabled auto-merge (squash) November 24, 2024 09:21
@Dream-Master Dream-Master merged commit 8c3e21c into master Nov 24, 2024
4 checks passed
@Dream-Master Dream-Master deleted the close-window-dialog-fallback branch November 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants