Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more recycling recipes #1096

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

Ableytner
Copy link
Contributor

closes GTNewHorizons/GT-New-Horizons-Modpack#17293
Also adds a recycling recipe to Reinforced Stone from IC2.

@Dream-Master Dream-Master requested a review from a team November 28, 2024 18:10
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recycling recipes should be added via itemdata. that means using GT_OreDictUnificator.addItemData or GT_OreDictUnificator.addItemDataFromInputs.

This gives the multiple recycling recipes, puts them in the right tabs, and allows inheritance of the data to other recipes.

see for example #936

@Dream-Master Dream-Master requested review from chochem and a team November 28, 2024 20:51
@chochem chochem added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Nov 30, 2024
@Dream-Master Dream-Master removed the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 8, 2024
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would have been easier to let the code do the math but this is fine.

@Dream-Master Dream-Master enabled auto-merge (squash) December 14, 2024 14:40
@Dream-Master Dream-Master merged commit fdbf604 into GTNewHorizons:master Dec 14, 2024
4 checks passed
@Ableytner Ableytner deleted the more-recycling-recipes branch December 14, 2024 16:06
Dream-Master pushed a commit that referenced this pull request Dec 15, 2024
Co-authored-by: Martin Robertz <dream-master@gmx.net>
(cherry picked from commit fdbf604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a recycling recipe for plated reinforced stone
3 participants