Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for preconfigured p2ps #1109

Merged
merged 8 commits into from
Dec 21, 2024

Conversation

EnderProyects
Copy link
Contributor

@EnderProyects EnderProyects commented Dec 16, 2024

@Dream-Master Dream-Master requested a review from a team December 16, 2024 09:33
@serenibyss
Copy link
Member

These recipes seem okay, though I wonder if there's a cleaner way to do it to avoid the added cost without needing to do something like 16 at a time.

What about allowing these P2Ps to chisel into eachother? Then you could also automate it by using multiple chisel buses as you see fit on a multiblock autochisel. (this is similar to modern ae2 as well, which does it with the stonecutter)

@EnderProyects
Copy link
Contributor Author

These recipes seem okay, though I wonder if there's a cleaner way to do it to avoid the added cost without needing to do something like 16 at a time.

What about allowing these P2Ps to chisel into eachother? Then you could also automate it by using multiple chisel buses as you see fit on a multiblock autochisel. (this is similar to modern ae2 as well, which does it with the stonecutter)

Well the other parts from ae2 that have variants are also crafted in circuit assembler, so I dont see why this should be different, also you are only needing this ones if you are doing things like assline or other stuff so mainly craft a lot, p2p are cheap, and the items used to change them are also very cheap

@EnderProyects
Copy link
Contributor Author

@serenibyss If you think that using this recipes is annoying or a nerf I could change them with chisel ( well I could but the attempts I have done with chisel haven't work, so I prefer not doing that) if not are you are okay with the recipes, I would like them to be in the next release ( that I think is tomorrow) 🙃

Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice QoL

@Dream-Master Dream-Master merged commit a114a25 into GTNewHorizons:master Dec 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recipes for different types of p2p tunnels
4 participants